Update gNMI specification to clarify Set error handling.
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (M) rpc/gnmi/gnmi-specification.md
- remove references to the deprecated `error` field in the
`SetResponse` and `UpdateResult` messages, explicitly
specifying the error handling behaviour follows the standard
gRPC error model.
wenovus
reviewed
Jul 8, 2022
There was a problem hiding this comment.
@dplore noted here that there is ambiguity as to what to return when multiple error codes are valid: #155 (comment)
|
In the case of multiple errors, I believe we should specify "the implementation SHOULD return the first error encountered" As a newcomer to gRPC, I found it useful to directly reference the standard gRPC return codes and this gRPC core doc page on status codes |
dplore
reviewed
Jul 8, 2022
| indicate that the encoding is not supported. | ||
| * When the client specifies a payload utilising an encoding that is not | ||
| supported by the target (e.g., JSON) - `Unimplemented (12)` SHOULD be used to | ||
| indicate that the encoding is not supported. | ||
|
|
There was a problem hiding this comment.
Suggested change
| * When the client specifies a value which is not permitted by the target - `Unimplemented (12)` | |
| SHOULD be used. For example, setting an interface full_duplex leaf to false when the interface | |
| only supports full_duplex. |
dplore
reviewed
Jul 8, 2022
There was a problem hiding this comment.
Please consider comments on
- additional use case for unimplemented (12) and In the case of multiple errors
- I believe we should specify "the implementation SHOULD return the first error encountered"
As a newcomer to gRPC, I found it useful to directly reference the standard gRPC return codes and this gRPC core doc page on status codes
I found these more straightforward to read than the referenced gRPC error handling guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62.